Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Keeping documentation consistent #4937

Closed
wants to merge 1 commit into from
Closed

Keeping documentation consistent #4937

wants to merge 1 commit into from

Conversation

thecatontheflat
Copy link
Contributor

No description provided.

stof
stof reviewed Jan 29, 2015
View reviewed changes
book/forms.rst
@@ -175,7 +175,7 @@ That's it! Just three lines are needed to render the complete form:
Renders all the fields, which includes the field element itself, a label
and any validation error messages for the field.

``form_end()``
``form_end(form)``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is no argument in form_end(). You can pass one because Twig ignores extra args, as done by PHP, but your documentation now tells that the argument is needed

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, sorry. It looks like it actually does something with the argument. I forgot it can do more than rendering the closing tag

@craue craue mentioned this pull request Jan 29, 2015
Closed
@craue
Copy link
Contributor

craue commented Jan 29, 2015

This should go into the 2.3 branch.

@wouterj
Copy link
Member

wouterj commented Jan 30, 2015

Thank you @thecatontheflat. Consistency is one of the most important bits of a documentation. I've merged it into the 2.3 branch (that's why this PR is not labelled as merged, but as closed instead).

wouterj added a commit that referenced this pull request Jan 30, 2015
@wouterj
minor #4937 Keeping documentation consistent (thecatontheflat)
0fa9cbd 
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #4937).

Discussion
----------

Keeping documentation consistent

Commits
-------

c30f470 Keeping documentation consistent
@wouterj wouterj closed this Jan 30, 2015
@thecatontheflat thecatontheflat deleted the patch-1 branch January 30, 2015 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thecatontheflat @craue @wouterj @stof