Add possible values for widget_type #4892
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation does not list which values are possible for widget_type. These two are the ones I extracted from the Symfony2 source code.
|
What do you think about reusing the description that we already have for the widget option of the |
|
Sure, that sounds even better. |
|
@XitasoChris Will you be able to do the change? I think this would be ready to be merged then. |
|
@xabbuh Should I just copy it or move it to a new file and then include it on both pages? |
|
@XitasoChris There already is the file |
|
@xabbuh The form types should be identical, but the block you pointed out has a different headline ("widget") whereas we need "date_widget" here. |
|
@XitasoChris Indeed, I would then move the description itself to its own file. |
|
@xabbuh Done. |
|
@XitasoChris Thanks, this looks really nice! 👍 |
|
Wow, really really nice job re-using the existing description. Thanks @XitasoChris and xabbuh! |
weaverryan
pushed a commit
that referenced
this pull request
Mar 24, 2015
weaverryan
pushed a commit
that referenced
this pull request
Mar 24, 2015
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2015
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #4892). Discussion ---------- Add possible values for widget_type | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | The documentation does not list which values are possible for widget_type. These two are the ones I extracted from the Symfony2 source code. Commits ------- e57c2ac terminate file with newline ef9e1bd move title back and move description to separate file as suggested in PR #4892 6b42685 move title out of included file as suggested in PR #4892 6fcdd89 Add possible values for widget_type
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2015
* 2.3: (44 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR #4892 move title out of included file as suggested in PR #4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request #4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to #4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. Update translation.rst ... Conflicts: cookbook/security/entity_provider.rst
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2015
* 2.6: (45 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR #4892 move title out of included file as suggested in PR #4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request #4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to #4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. Update translation.rst ...
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2015
* 2.7: (47 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR #4892 move title out of included file as suggested in PR #4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request #4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component Changes thanks to WouterJ and xabbuh [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to #4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation does not list which values are possible for widget_type. These two are the ones I extracted from the Symfony2 source code.