Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reference] fix from suffix to prefix #4136

Merged
merged 1 commit into from
Aug 21, 2014
+6 −6
Merged

[Reference] fix from suffix to prefix #4136

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions reference/constraints/File.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ to be valid. The size of the file can be given in one of the following formats:
| Mi | mebibyte | 1,048,576 bytes | 8Mi |
+--------+-----------+-----------------+------+

For more information about the difference between binary and SI suffixes,
For more information about the difference between binary and SI prefixes,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm also fine with this change

see `Wikipedia: Binary prefix`_.

binaryFormat
Expand All @@ -188,12 +188,12 @@ binaryFormat

**type**: ``boolean`` **default**: ``null``

When ``true``, the sizes will be displayed in messages with binary suffixes
(KiB, MiB). When ``false``, the sizes will be displayed with SI suffixes (kB,
MB). When ``null``, then the binaryFormat will be guessed from the suffix
defined in the ``maxSize`` option.
When ``true``, the sizes will be displayed in messages with binary-prefixed
units (KiB, MiB). When ``false``, the sizes will be displayed with SI-prefixed
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice, there is no confusion here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm cool with this change too

units (kB, MB). When ``null``, then the binaryFormat will be guessed from
the value defined in the ``maxSize`` option.

For more information about the difference between binary and SI suffixes,
For more information about the difference between binary and SI prefixes,
see `Wikipedia: Binary prefix`_.

mimeTypes
Expand Down