-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A set of small typos #4130
A set of small typos #4130
Conversation
Baptouuuu
commented
Aug 16, 2014
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | 2.3+ |
Fixed tickets |
Oops, the target branch should be |
@Baptouuuu These are really nice catches! 👍 And don't worry about the target branch. @weaverryan can easily apply the changes to the right branch. |
Great fixes! However, almost all of the fixes in this PR should be merged in the 2.3 branch, except from the change in |
@wouterj done. |
Thanks @Baptouuuu |
Hey @Baptouuuu! I need to merge this into the 2.3 branch, but it's not merging cleanly. If you can rebase this against the 2.3 branch and re-push (not need to open a new PR), then I can merge it in. Assuming git fetch upstream
git checkout typos
git rebase --onto upstream/2.3 upstream/master
git push origin typos --force Thanks! |
This reverts commit a0de688 as it's intended for 2.5.
@weaverryan done |
Yes! This merged into 2.3 perfectly. Thanks Baptiste! |