Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created Documentation CHANGELOG #3558

Merged
merged 2 commits into from
Feb 18, 2014
Merged

Created Documentation CHANGELOG #3558

merged 2 commits into from
Feb 18, 2014

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Feb 8, 2014

Q A
Doc fix? no
New docs? yes
Applies to 2.3+
Fixed tickets #2579

This is the second enhancement (after #3328) of the Symfony2 Documentation Process.

This idea came from @shoomyth in #2579. Since @weaverryan is using gh to merge the Pull Requests, it's easy to scan through the commits and find the changes (I'm busy creating an automated script for this).

The plan is to update the changelog each month, so people have a clear view on new articles or fixed things. It'll also be another attribution to the many symfony doc hero's!
This PR lists the changes in the 2.3 branch for January. When we agree with this, it'll be update for changes in the 2.4 and master branches.

My idea was to put a link to this article in the sidebar (ping @fabpot).

We would love to get your opinion about this new change!

Fixed Documentation
~~~~~~~~~~~~~~~~~~~

- `e385d28 <https://github.com/symfony/symfony-docs/commit/e385d28bee7c7418c8175d43befc4954a43a300c>`_ #3503 file extension correction xfliff to xliff (nixilla)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was easier for me to link to the commit than to link to the PR. In the feature, we may change this so that it displays the changed files.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should think about creating an extension that makes linking to a certain commit easier.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, we can always make this change later - piece by piece :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. :)

@wouterj
Copy link
Member Author

wouterj commented Feb 16, 2014

Thank you @xabbuh !

For some reason, my editor decided it was better to use tabs in reSt documents...

@weaverryan
Copy link
Member

I don't see any issues with this. Certainly we could potentially make some improvements, but it's a great start and @wouterj has a script that's able to generate all of this automatically (so we get the CHANGELOG basically for free).

Thanks @wouterj for taking this on! I'll merge it in now

weaverryan added a commit that referenced this pull request Feb 18, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Created Documentation CHANGELOG

| Q   | A
| --- | ---
| Doc fix? | no
| New docs? | yes
| Applies to | 2.3+
| Fixed tickets | #2579

This is the second enhancement (after #3328) of the Symfony2 Documentation Process.

This idea came from @shoomyth in #2579. Since @weaverryan is using gh to merge the Pull Requests, it's easy to scan through the commits and find the changes (I'm busy creating an automated script for this).

The plan is to update the changelog each month, so people have a clear view on new articles or fixed things. It'll also be another attribution to the many symfony doc hero's!
This PR lists the changes in the 2.3 branch for January. When we agree with this, it'll be update for changes in the 2.4 and master branches.

My idea was to put a link to this article in the sidebar (ping @fabpot).

We would love to get your opinion about this new change!

Commits
-------

401737b Applied comments from @xabbuh
a6c68a9 Added CHANGELOG for 2.3
@weaverryan weaverryan merged commit 401737b into symfony:2.3 Feb 18, 2014
@wouterj wouterj deleted the changelog branch February 18, 2014 19:23
@wouterj
Copy link
Member Author

wouterj commented Feb 18, 2014

@fabpot can you maybe update the sidebar menu with this?

@wouterj
Copy link
Member Author

wouterj commented Feb 18, 2014

and of course, @weaverryan thanks! I'll take a look at the other versions and try to improve my script in the comming weeks, so we are able to just run a script every month

@lyrixx
Copy link
Member

lyrixx commented Feb 18, 2014

Ping @javiereguiluz

@wouterj
Copy link
Member Author

wouterj commented Feb 18, 2014

Ah, is @javiereguiluz the one which should be pnged for symfony.cœm related things? Good to know :)

@lyrixx
Copy link
Member

lyrixx commented Feb 18, 2014

It's a bit new and It has been said at SymfonyCon (varsaw 2013) ;) So this is not a secret ;)

@xabbuh
Copy link
Member

xabbuh commented Feb 18, 2014

I feel that there will be a lot of pings for him in the next days. ;)

@lyrixx
Copy link
Member

lyrixx commented Feb 18, 2014

@javiereguiluz will hate me for that... Sorry.

@wouterj
Copy link
Member Author

wouterj commented Feb 18, 2014

@lyrixx I wasn't at Warsaw and didn't catch up with the videos, so didn't knew :)

@xabbuh no, a new design is coming, so I'll wait :p

@javiereguiluz
Copy link
Member

In the coming weeks we're going to explain publicly more details about the redesign of symfony.com. Meanwhile I can tell you that this redesign is going to be gradual, page by page. Due to the vast complexity of the documentation section, this is not going to be one of the first sections to be redesigned.

Therefore, I think that we should add a link to the changelog in the current website. My question is if you just want a link to the changelog file in the repository or if you want full integration of the changelog file inside the symfony.com website. The first option would be online in a few days while the other one would require some undefined amount of time.

@xabbuh
Copy link
Member

xabbuh commented Feb 19, 2014

Linking to the repository file imho is no option since most ReSt directives aren't rendered properly. However, we can use it as a temporarily solution until we have a better one I guess.

@wouterj
Copy link
Member Author

wouterj commented Feb 19, 2014

@javiereguiluz I thought it would be rendered on http://symfony.com/doc/2.3/changelog.html, just like all other doc articles? Or doesn't that apply to the root files?

I think in the end, we should render it online. But as a temporarily solution, we can just use the link to the repo. Since the CHANGELOG file contains only basic RST markup (no usage of fabian's sphinx extensions), there are no rendering issues on github (@xabbuh). And as it'll properbly only be used by a small group, it wouldn't make that much of a difference.

@wouterj
Copy link
Member Author

wouterj commented Mar 10, 2014

I've now updated the changelog files for all branches.

@javiereguiluz can you please add the link?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants