Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Console] The interactive shell is deprecated #5729

Closed
xabbuh opened this issue Sep 26, 2015 · 5 comments
Closed

[Console] The interactive shell is deprecated #5729

xabbuh opened this issue Sep 26, 2015 · 5 comments
Labels
actionable Clear and specific issues ready for anyone to take them. Console good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
2.8

Comments

@xabbuh
Copy link
Member

xabbuh commented Sep 26, 2015

The interactive shell will be deprecated in Symfony 2.8 (see symfony/symfony#15892) and we should reflect the fact in the documentation (it is described in the cookbook).
@xabbuh xabbuh added good first issue Ideal for your first contribution! (some Symfony experience may be required) actionable Clear and specific issues ready for anyone to take them. Console labels Sep 26, 2015
@xabbuh xabbuh added this to the 2.8 milestone Sep 26, 2015
@Tobion
Copy link
Contributor

Tobion commented Sep 27, 2015

Code Removed in symfony/symfony#15936

@Tobion Tobion mentioned this issue Sep 27, 2015
Merged
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Sep 27, 2015
xabbuh added a commit that referenced this issue Oct 3, 2015
@xabbuh
minor #5730 Remove documentation of deprecated console shell (Tobion)
a906993 
This PR was merged into the 2.8 branch.

Discussion
----------

Remove documentation of deprecated console shell

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.8
| Fixed tickets | #5729

Commits
-------

14bea43 Remove documentation of deprecated console shell
@xabbuh
Copy link
Member Author

xabbuh commented Oct 17, 2015

@Tobion and I talked about this and we thought that it could be a good idea to remove the documentation for this feature in older branches too.

@javiereguiluz @weaverryan @wouterj What do you think?

@wouterj
Copy link
Member

wouterj commented Oct 17, 2015

Afaik, our normal plan with deprecations is to show a big caution box before the description of a deprecated feature in older versions and only remove it in the 3.0 version. I think we should do the same here.

@javiereguiluz
Copy link
Member

I agree with @wouterj.

@weaverryan
Copy link
Member

This is already merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. Console good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
5 participants
@javiereguiluz @weaverryan @Tobion @wouterj @xabbuh