Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for cookbook/form/form_collections.html page #3442

Closed
ifdattic opened this issue Jan 8, 2014 · 3 comments
Closed

Suggestion for cookbook/form/form_collections.html page #3442

ifdattic opened this issue Jan 8, 2014 · 3 comments
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@ifdattic
Copy link
Contributor

ifdattic commented Jan 8, 2014

I think in How to Embed a Collection of Forms page, on the block:

Let's start there: suppose that each Task belongs to multiple Tags objects. Start by creating a simple Task class:

it might be good to change multiple Tags objects to multiple Tag objects
@peterrehm
Copy link
Contributor

@ifdattic It would be awesome if you could click the edit button on the doc page and propose a PR with the typo fix with a reference to this issue.

@ifdattic ifdattic mentioned this issue Jan 8, 2014
Merged
weaverryan added a commit that referenced this issue Jan 10, 2014
@weaverryan
bug #3444 Fix issue #3442 (ifdattic)
d9d7c58 
This PR was merged into the 2.3 branch.

Discussion
----------

Fix issue #3442

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3
| Fixed tickets | #3442

Commits
-------

559a227 Fix issue #3442
@peterrehm
Copy link
Contributor

Thanks @ifdattic!

@ifdattic
Copy link
Contributor Author

Sure, glad to help

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @ifdattic @peterrehm