Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documenting overriden options #3412

Closed
25 tasks done
wouterj opened this issue Jan 3, 2014 · 1 comment
Closed
25 tasks done

Documenting overriden options #3412

wouterj opened this issue Jan 3, 2014 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required)

Comments

@wouterj
Copy link
Member

wouterj commented Jan 3, 2014

A lot overriden options are not yet documented. For information how to document these, refer to #2361

Missing overriden options

button

checkbox

choice

datetime

date

file

hidden

integer

money

number

password

percent

text

time

timezone

  • overrides choices instead of choice_list
nykopol referenced this issue in nykopol/symfony-docs Jan 3, 2014
weaverryan added a commit that referenced this issue Feb 3, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Nykopol overriden options

See #3417 - this is just a rebase to continue it :)

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3
| Fixed tickets | #3412

Thanks!

Commits
-------

e574e97 Removing an extra line thanks to @xabbuh
4f6cb9d Some additional tweaks and probably some merge conflict fixes
362c8b4 document overriden options of choice field
70feefd document overriden options of checkbox
c62cd13 correct overriden option of button and add checkbox overriden option
ab4aafe correct overriden option of button and add checkbox overriden option
@wouterj
Copy link
Member Author

wouterj commented Dec 13, 2014

A couple options are documented correctly now, just some to go!

wouterj added a commit that referenced this issue Apr 2, 2015
…kalenyuk)

This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5124).

Discussion
----------

#3412 correct overridden option name of timezone

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.6
| Fixed tickets | #3412

Commits
-------

dd3b6fb #3412 correct overridden option name of timezone
weaverryan added a commit that referenced this issue Jun 28, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

Documented the overridden form options

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | all
| Fixed tickets | #3412

Commits
-------

84633db Fixed a typo
596a0bc Reordered two overridden options
62a11d5 Added missing types in overridden options
2b63f24 Fixed the order of the different options
e14b650 Fixed the order of the different options
0a5781b Improved the explanation about the "compoun" option
eb20dc8 Fixer minor issues
974dfef Fixed errors noticed by Wouter
32c0af1 Removed a duplicated "trim" option in the "password" type
1dc53fa Removed again a duplicated option explanation
7f8e09a Removed a duplicated option explanation in "file" type
48b402b Extracted the common "data_class" option explanation for data-related types
f44e971 Documented the overridden options of "date" type
e41b3cc Documented overridden options for "file" type
8e825d9 Documented the overridden options of the "password" type
618e11d Documented the overridden options for "time" type
7ce8191 Documented overridden options for hidden field
a8ad338 Documented overriden options for numeric types
e66ec5c Created a compound_type file because this option is shared with lots of types
8d360d9 Documented the Overridden Options of the Text type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
actionable Clear and specific issues ready for anyone to take them. Form good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Development

No branches or pull requests

2 participants