-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rechecking inherit options #2360
Comments
I checked all form types for their parent types and links to the API docs of their classes. They are all fine. When it comes to options, I see one issue first: the order of options. To me, it seems as if options are ordered mainly randomly inside their sections (section meaning one of Options, Inherited Options, Overridden Options). I don't think that this a good way. When people use the reference to find out what a particular option does. With the current situation, they would look at the list of options on top of the page which may be very long depending on the form type. Without some luck or using the search function of your browser, you may easily overlook the option you were look for. Seeing this from a development experience point of view, that's not really satisfying and I think we can do better. For example, we can order the options in each section in alphabetical order. In the worst situation, you would only have to check three possible positions (the option you are looking for can be in any of the three sections). I think that would make it much easier to find the particular option you are looking for. What do you think? |
Great as always! I've marked it as done
100% agree with your idea. +1 for alphabetical order |
I have to correct myself. Obviously, I didn't look carefully enough. The parent types of the |
This PR was merged into the 2.3 branch. Discussion ---------- fix parent form types | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | part of #2360 The parent type of both the email type and the textarea type is not the form type but instead the text type. Commits ------- 0af354f fix parent form types
This PR was merged into the 2.3 branch. Discussion ---------- [Reference] order form type options alphabetically | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | related to #2360 Commits ------- 99ca7bf [Reference] order form type options alphabetically
The options are now ordered alphabetically. So, if anyone is willing to step up checking the options. :) |
Perhaps (see #4152) we should explicitly add a todo in this issue to add the |
Yes, we should make this issue more concrete when we have specific tasks to do. |
Should we somehow define what we understand by "relevant options"? So, that someone who wants to pick this know what to look after? |
This issue is ivery old but it seems very important. Which is the real state of the issue? Do we have an updated list of the options defined by all form fields for 2.6 or 2.7? Thanks. |
Today I wanted to change the translation domain of a text field and the option wasn´t in the documentation at http://symfony.com/doc/current/reference/forms/types/text.html I found the option later by clicking on the following link: http://symfony.com/doc/current/reference/forms/types/form.html Should we document all inherited options or just "relevant" ones? |
@javiereguiluz , is this issue still relevant? |
I'm afraid it's still relevant. Someone should very carefully check if all options (including inherited ones) are listed for all form types. It's a extremely boring and time-consuming task :( |
I'm closing as fixed because in #12302 we added the missing |
Form Types can be represented with a tree. Some types inherits each other and all form types inherits the
field
type (as of Symfony 2.0,form
in 2.1).We currently have a Inherit options section in each reference article with some relevant inherit options. In order to keep this up to date, someone needs to:
options that should get placed here?
relevant enough to get documented on this page. This to avoid long
articles.
A 'tree' of all parent/child relations (in 2.0) and their options can be found in this gist.
The text was updated successfully, but these errors were encountered: