Skip to content

Commit

Permalink
minor #4200 Moved 'contributing' images to their own directory (javie…
Browse files Browse the repository at this point in the history
…reguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Moved 'contributing' images to their own directory

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #3192

The PDF version of the "Contributing Guide" doesn't show the images (as reported in #3192). The rest of the PDFs correctly show them. Although I don't know the exact cause of the error, the "Contributing" guide images weren't stored in their own subdirectory inside `images/` and named after the book. That's the only difference between the right and the wrong PDF files.

For compatibility reasons I've left on purpose the original images at their location and just made a copy in the new directory.

Commits
-------

fc15b65 Moved 'contributing' images to their own directory
  • Loading branch information
weaverryan committed Sep 15, 2014
2 parents b4650fa + fc15b65 commit f8c6201
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion contributing/community/releases.rst
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ Schedule

Below is the schedule for the first few versions that use this release model:

.. image:: /images/release-process.jpg
.. image:: /images/contributing/release-process.jpg
:align: center

* **Yellow** represents the Development phase
Expand Down
2 changes: 1 addition & 1 deletion contributing/documentation/overview.rst
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ If you have made your changes based on the 2.3 branch then you need to change
the base branch to be 2.3 on the preview page by clicking the ``edit`` button
on the top left:

.. image:: /images/docs-pull-request-change-base.png
.. image:: /images/contributing/docs-pull-request-change-base.png
:align: center

.. note::
Expand Down
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added images/contributing/release-process.jpg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit f8c6201

Please sign in to comment.