Skip to content

Commit

Permalink
Merge branch '5.4' into 6.3
Browse files Browse the repository at this point in the history
* 5.4:
  Fix implicitly-required parameters
  List CS fix in .git-blame-ignore-revs
  Apply php-cs-fixer fix --rules nullable_type_declaration_for_default_null_value
  [Messenger][AmazonSqs] Allow async-aws/sqs version 2
  • Loading branch information
nicolas-grekas committed Jan 23, 2024
2 parents 0cafa10 + b84e479 commit b9dac8f
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion Transport/MandrillApiTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ class MandrillApiTransport extends AbstractApiTransport

private string $key;

public function __construct(string $key, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
public function __construct(string $key, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null)
{
$this->key = $key;

Expand Down
2 changes: 1 addition & 1 deletion Transport/MandrillHeadersTrait.php
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
*/
trait MandrillHeadersTrait
{
public function send(RawMessage $message, Envelope $envelope = null): ?SentMessage
public function send(RawMessage $message, ?Envelope $envelope = null): ?SentMessage
{
if ($message instanceof Message) {
$this->addMandrillHeaders($message);
Expand Down
2 changes: 1 addition & 1 deletion Transport/MandrillHttpTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ class MandrillHttpTransport extends AbstractHttpTransport
private const HOST = 'mandrillapp.com';
private string $key;

public function __construct(string $key, HttpClientInterface $client = null, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
public function __construct(string $key, ?HttpClientInterface $client = null, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null)
{
$this->key = $key;

Expand Down
2 changes: 1 addition & 1 deletion Transport/MandrillSmtpTransport.php
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class MandrillSmtpTransport extends EsmtpTransport
{
use MandrillHeadersTrait;

public function __construct(string $username, #[\SensitiveParameter] string $password, EventDispatcherInterface $dispatcher = null, LoggerInterface $logger = null)
public function __construct(string $username, #[\SensitiveParameter] string $password, ?EventDispatcherInterface $dispatcher = null, ?LoggerInterface $logger = null)
{
parent::__construct('smtp.mandrillapp.com', 587, false, $dispatcher, $logger);

Expand Down

0 comments on commit b9dac8f

Please sign in to comment.