Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix conversion of large integers #426

Merged
merged 1 commit into from
Jan 10, 2023
Merged

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Oct 14, 2022

No description provided.

@rikardn
Copy link
Contributor

rikardn commented Oct 14, 2022

Is this because it didn't work properly before or to speed up the construction?

@isuruf
Copy link
Member Author

isuruf commented Oct 14, 2022

This should speed up the construction a bit and also fix large int/str conversions broken by the latest cpython releases.
See sympy/sympy#24033

@rikardn
Copy link
Contributor

rikardn commented Oct 18, 2022

Ok, interesting! Then symengine comes out of this quite easily compared to sympy.

@bjodah bjodah merged commit c24a309 into symengine:master Jan 10, 2023
@isuruf isuruf deleted the conv_big_int branch January 14, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants