Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix leading underscore in converted dummy name by slicing #375

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

ayushk7102
Copy link
Contributor

Possible fix for #372 (leading underscore appearing in converted dummy type)
Modified line 1265 from:
return sympy.Dummy(str(self))
to
return sympy.Dummy(str(self)[1:]

@ayushk7102
Copy link
Contributor Author

I'm getting the error in the AppVeyor build:
CMake Error at C:/Program Files (x86)/CMake/share/cmake-3.16/Modules/FindPackageHandleStandardArgs.cmake:146 (message): Could NOT find GMP (missing: GMP_LIBRARIES GMP_INCLUDE_DIRS)
Is there anything I can do to fix this?

@isuruf
Copy link
Member

isuruf commented Oct 18, 2021

Looks good to me. Can you add a test?

You can ignore the appveyor failure

@isuruf isuruf merged commit 4978e0b into symengine:master Oct 18, 2021
@ayushk7102 ayushk7102 deleted the fix_converted_Dummy_return branch October 18, 2021 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants