Fix race condition where ComponentTemplateParser.php.inc can be loaded instead of ComponentTemplateParser.php, causing the custom template code to not work.

[silbinarywolf]

The problem
The class manifest is scanning the module directory for classes. However it seems that it's scanning both ComponentTemplateParser.php and ComponentTemplateParser.php.inc (used to generate *.php version).

It will sometimes use that class instead of the generated class, causing templates to not load/work properly. This can result in ArrayData / SS_List calling forTemplate() errors in a way that's incredibly hard to debug.

EDIT: It seems whats happening is the PSR-4 autoload of Composer is picking up the .php.inc file. The SilverStripe class manifest scanner only works on *.php files.

The solution
Rename ComposerTemplateParser.php.inc to ComposerTemplateParser.peg. This is what SilverStripe 4+ does and this should stop the ClassManifest from picking up the file.

.gitattributes also needs to be updated to ignore exporting the newly renamed *.peg file.

Affected versions

• 1.0.0 (SilverStripe 3)
• 2.0.0 (SilverStripe 4)

[silbinarywolf]

This is now fixed in:

• 1.0.1 (SilverStripe 3)
• 2.0.1 (SilverStripe 4)