Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Email notification workflow now ignores recipients with invalid email addresses #370

Merged

Conversation

robbieaverill
Copy link
Contributor

@robbieaverill robbieaverill commented Jun 28, 2018

Swift mailer in SilverStripe 4 will throw a Swift_RfcComplianceException exception when setTo is called with an invalid email address (like admin).

This change ignores invalid email address formats, rather than letting this exception break the workflow.

Fixes half of #358

Copy link
Contributor

@raissanorth raissanorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good solution!

Copy link
Contributor

@NightJar NightJar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought SwiftMailer would have a validity check one could leverage rather than relying on catching exceptions... but never the less in light that it doesn't (nor does it particularly matter) this is good :)

@NightJar NightJar merged commit aa69aa5 into symbiote:5.0 Jun 29, 2018
@NightJar NightJar deleted the pulls/5.0/handle-dodgy-emails branch June 29, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants