Tentative fix for saving records with new workflow #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still breaks on subsequent save & publish, but the first one works
robbieaverill
suggested changes
Jan 31, 2018
| if (isset($changed['WorkflowDefinitionID']) && | ||
| ( | ||
| empty($changed['WorkflowDefinitionID']['before']) | ||
| || empty($changed['WorkflowDefinitionID']['before']) |
There was a problem hiding this comment.
Are these the same thing?
There was a problem hiding this comment.
It appears to be, yep. Perhaps the first was supposed to be isset.
There was a problem hiding this comment.
isset would be covered by empty anyway, maybe we just need the one
| // Ignore canPublish() if in the middle of having workflow added / removed | ||
| $key = $this->owner->baseClass() . '#' . $this->owner->ID; | ||
| if (isset(static::$itemsChangingWorkflow[$key])) { | ||
| return null; |
There was a problem hiding this comment.
I feel like false would suit the method name better, assuming it should return a bool (unless false and null have different results for the user, like a validation error)
There was a problem hiding this comment.
They do, and this has been addressed in #345
|
This pull request is now superseded by #345 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still breaks on subsequent save & publish, but the first one works
Stop gap fix for #333