fix: Correct minVersion required (#15)

* fix minVersion required

* x

src/utils/versions.test.ts

@@ -2,7 +2,11 @@ import { assert } from "../../deps_test.ts";
 import { assertMinVersion } from "./versions.ts";
 
 Deno.test("assertMinVersion", () => {
+  // should be good
   assert(assertMinVersion("1.1.5", "1.0.1"));
   assert(assertMinVersion("2.0.5", "1.0.1"));
+  assert(assertMinVersion("1.30.0", "1.29.1"));
+  // not good
   assert(!assertMinVersion("1.0.5", "2.0.0"));
+  assert(!assertMinVersion("1.27.5", "1.30.0"));
 });

src/utils/versions.ts

@@ -1,8 +1,16 @@
-// ** does not handee '- name'
 export function assertMinVersion(version: string, minRequired: string) {
-  const minArr = minRequired.split(".");
-  return version.split(".").every((v, i) => {
-    if (i < 3 && +v >= +minArr[i]) return true;
-    return false;
-  });
+  const minArr = minRequired.split(".").map((v) => +v);
+  const versionArr = version.split(".").map((v) => +v);
+
+  // compare major
+  if (versionArr[0] < minArr[0]) return false;
+  if (versionArr[0] > minArr[0]) return true;
+
+  // compare minor
+  if (versionArr[1] < minArr[1]) return false;
+  if (versionArr[1] > minArr[1]) return true;
+
+  // compare patch
+  if (versionArr[2] < minArr[2]) return false;
+  return true;
 }