Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Elisp tweaks #2887

Closed
wants to merge 3 commits into from
Closed

Elisp tweaks #2887

wants to merge 3 commits into from

Conversation

luxbock
Copy link

@luxbock luxbock commented Sep 4, 2015

No description provided.

luxbock added 3 commits September 4, 2015 23:36
- ,gg and ,hh should work from inside
- enable smartparens
- command to set the buffer ielm is attached to
@dcluna
Copy link
Contributor

dcluna commented Oct 14, 2015

Didn't review the PR per se, but according to contribution guidelines, there should be only one commit per PR.

You also need to update your branch, so I'd git pull --rebase this branch, and then squash the 3 commits into one.

@StreakyCobra
Copy link
Contributor

As said, this should be rebased and squased in order to get reviewed :-)

@Compro-Prasad
Copy link
Contributor

@syl20bnr Any chances of getting this into spacemacs?

@syl20bnr
Copy link
Owner

syl20bnr commented May 24, 2018 via email

@Compro-Prasad
Copy link
Contributor

@luxbock Can you give us some feedback on what this PR is all about?

@Compro-Prasad
Copy link
Contributor

@syl20bnr I think this can safely be closed. @luxbock is offline for a long period. Or probably wait for 2 more years?

@sdwolfz
Copy link
Contributor

sdwolfz commented Aug 1, 2018

I'll go ahead and close this PR due to it's inactivity, and because some of the functionality is already present in the current develop. If somebody wants to revive it then please open a new PR with the bits missing and with an explanation in the message.

@sdwolfz sdwolfz closed this Aug 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants