Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating links in *Help* buffer loses focus #2659

Closed
sooheon opened this issue Aug 14, 2015 · 6 comments
Closed

Navigating links in *Help* buffer loses focus #2659

sooheon opened this issue Aug 14, 2015 · 6 comments

Comments

@sooheon
Copy link

sooheon commented Aug 14, 2015

Whenever a Help buffer pops up, it has focus at first by default, to make it easy to escape with a single q keypress. However, if you navigate to a link and press enter, your point will move to another window, and the new Help window will not have focus. This breaks flow, because you can't keep navigating through links, and you can't easily close the window.

@sooheon
Copy link
Author

sooheon commented Aug 15, 2015

I've found that (setq help-window-select 't) resolves this issue. @syl20bnr, what do you think about adding this to spacemacs config.el?

@syl20bnr
Copy link
Owner

Testing it... I' m not sure to understand the use case :-)

@syl20bnr
Copy link
Owner

I don't see any difference, can you provide a repro step ?

@sooheon
Copy link
Author

sooheon commented Aug 15, 2015

On spacemacs develop branch with no personal layers settings:

  1. q to dismiss spacemacs-buffer
  2. C-h v emacs-lisp-mode-map to open a help buffer
  3. o b to select a link, now point moves to scratch buffer. The desired behaviour is that point stays in help.

Eval (setq help-window-select t) and repeat above steps, you will see that traversing links keeps point in help buffer, so you can dismiss at any time with q, and go back and forth in history easily.

@syl20bnr
Copy link
Owner

Ok I understand now, this is nice, we can add it.
For the issue of the changing layout (when pression ob on a vertically split layout, the layout changes from 3 windows to 2 windows) I think we will be able to stabilize it with windows purpose package (planned to be configured for 0.105.0).

@mkcode
Copy link
Contributor

mkcode commented Aug 17, 2015

👍 - This has slightly annoyed me for a while as well. Thanks @sooheon

sooheon pushed a commit to sooheon/spacemacs that referenced this issue Sep 28, 2015
syl20bnr pushed a commit that referenced this issue Oct 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants