-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request to add notmuch #2163
Comments
@kvaneesh There is already a gnus layer - https://github.com/syl20bnr/spacemacs/tree/master/contrib/!email/gnus - please feel free to contribute a layer for notmuch - https://github.com/syl20bnr/spacemacs/blob/master/doc/DOCUMENTATION.md#configuration-layers |
I am not sure how a gnus layer would help. I currently have a private layer which does minimal stuff. But I don't enough to remap (SPC) which is used by notmuch layer. NOTE: I solved that by using different keybinding instead of SPC in notmuch. |
I've been playing with notmuch a little bit in the last weeks and have started a private layer for it. But there is a lot of stuff that is not working. There are also issues with the starting page of notmuch and evil-movement keys. |
@cpaulik Does your |
No. I'm using mu4e now. |
I won't be switching to mu4e, and I am also not in a position to contribute the notmuch layer. So if you are looking at closing this issue, because nobody is going to look at this soon, please feel free to do so. -aneesh |
No no, your request is valid, I was just trying to see if there was some news on this side |
There's some work on it done by @lehoff It will be linked or backlinked here when it's published :D |
I have raised #5239 re the collision I have with key bindings. If someone finds my notmuch layer of any use, then I could clean it up. |
@lehoff It would definitely be appreciated! |
Hi, I have put something together, but it might be too specific for my usage to https://github.com/lehoff/dotfiles/tree/master/my-notmuch E.g., I have my sendmail info in there, I use msmtp to queue my mail and I If someone has a good recommendation on how to separate those things out And I am open to changing some of the keymappings. I am using T to trash a Thoughts are most welcome. With some guidance we can have a layer for notmuch out very soon. Cheers, On 31 May 2016 at 22:33, Wolodja Wentland notifications@github.com wrote:
|
Any progress on this? |
I wish! |
I'm also quite interested on this one, I am putting some stuff together most of the code coming from @lehoff What I did so far lives in this commit FrancescElies@f307d81e Would someone be interested in helping out? |
Would someone be interested in helping out?
Yes! I have some time this week to test this.
|
I have limited connectivity (I'm in the middle of the woods somewhere)
so I can't do an extensive review via GitHub's interface. So I'll do
that here. I have a few comments:
## Message archiving
`spacemacs/notmuch-message-archive`:
I noticed when archiving from the search view it was using a custom
archiving routine (+archive -inbox -unread). This shouldn't be necessary
since `notmuch-search-archive-thread` does the same thing and can be
customized by changing `notmuch-archive-tags`. This also makes
`spacemacs/archive-by-removing-inbox-tag` redundant as well.
## zz bindings
Another thing that I think we should do is make the zz,zt,zb,etc evil
bindings work in notmuch-show. I use these a lot when reading email and
having to `f d z t` is a bit annoying. Right now z is bound to tree view
search so we could rebind that.
## custom hooks
```elisp
;; from https://github.com/fgeller/emacs.d/blob/master/email.org
(add-hook 'notmuch-show-hook 'spacemacs/notmuch-show-prefer-html-over-text)
```
Should the notmuch layer be opinionated about how email is shown? There is
already a bunch of customizable options in notmuch-show for this.
## message-sendmail-f-is-evil
```elisp
(setq message-sendmail-f-is-evil 't)
```
The notmuch layer probably shouldn't be opinionated about how email is sent...
## fixed previous buffer issue
```elisp
;; fixes: killing a notmuch buffer does not show the previous buffer
(push "\\*notmuch.+\\*" spacemacs-useful-buffers-regexp)
```
OMG this was such a pain! Thanks!
I have some of my working patches at `github/jb55/spacemacs/notmuch-layer`,
mostly with respect to the message archiving issue for now. Let me know what you
think. Other than that it seems to be working great! I've just started testing
this so I'll add more comments if I have any more.
|
William Casarin <notifications@github.com> writes:
## fixed previous buffer issue
```elisp
;; fixes: killing a notmuch buffer does not show the previous buffer
(push "\\*notmuch.+\\*" spacemacs-useful-buffers-regexp)
```
OMG this was such a pain! Thanks!
I also have:
(push "\\*unsent mail.*\\*" spacemacs-useful-buffers-regexp)
Though I suspect that buffer naming doesn't come from notmuch, so maybe
it's not the notmuch layers business to push that regexp. It is useful
though.
cheers
|
@jb55, I agree with your points, I added two more commits on top of yours addressing your suggestions. @mpe do you also have a branch with your configurations and stuff you would like to share? |
@jb55, I agree with your points, I added a commit two more commits on top of yours addressing your suggestions.
One to removing stuff and the other one addressing the `zz bindings`.
After thinking about it some more I'm a bit reluctant about the zz
bindings. My "real" goal was to have normal-mode-like feel when reading
email. Such as jumping around paragraphs with { and }, etc. I'm not sure
if there's a way to retain normal-mode bindings somehow.
I'm not that familiar with evilified states so I'm not even sure if this
is possible. For now I think we shouldn't re-add normal mode mappings to
the notmuch-show evilified state as that seems a bit ad-hoc...
|
After thinking about it some more I'm a bit reluctant about the zz bindings. My "real" goal was to have normal-mode-like feel when reading email. Such as jumping around paragraphs with { and }, etc. I'm not sure if there's a way to retain normal-mode bindings somehow. I'm not that familiar with evilified states so I'm not even sure if this is possible. For now I think we shouldn't re-add normal mode mappings to the notmuch-show evilified state as that seems a bit ad-hoc... @braham-snyder mentioned[1] that was working on something along these lines [1] syl20bnr#2163 (comment)
@jb55 I am also not sure how to address that, the |
@braham-snyder Interesting, thanks for sharing! If I understand correctly this changes are in your fork only, right? |
@jb55 I picked @braham-snyder's commit braham-snyder@24e91f8, I will give it a shot during this week. |
commit 9f9a7b8 Author: braham <braham.snyder@gmail.com> Date: Wed Aug 23 11:55:51 2017 -0500 WIP evilified-state: fallback to motion-state keybindings, not global * Un-special-case `edebug-mode-map` in the process (otherwise at least some motion-state keybindings shadow `edebug-mode-map` keybindings: e.g., "w") commit d1f0971 Author: Francesc Elies Henar <francesc.elies@gmail.com> Date: Thu Aug 24 16:35:39 2017 +0200 updates readme commit 6792f9e Author: Francesc Elies Henar <francesc.elies@gmail.com> Date: Mon Aug 28 22:21:39 2017 +0200 adds gf to readme commit 979d05b Author: Francesc Elies Henar <francesc.elies@gmail.com> Date: Mon Aug 28 22:21:22 2017 +0200 adds helm notmuch binding to show mode commit eebb2a3 Author: William Casarin <jb55@jb55.com> Date: Sat Aug 26 08:00:09 2017 -0700 notmuch: remove scroll bindings After thinking about it some more I'm a bit reluctant about the zz bindings. My "real" goal was to have normal-mode-like feel when reading email. Such as jumping around paragraphs with { and }, etc. I'm not sure if there's a way to retain normal-mode bindings somehow. I'm not that familiar with evilified states so I'm not even sure if this is possible. For now I think we shouldn't re-add normal mode mappings to the notmuch-show evilified state as that seems a bit ad-hoc... @braham-snyder mentioned[1] that was working on something along these lines [1] syl20bnr#2163 (comment) commit d7333ed Author: William Casarin <jb55@jb55.com> Date: Thu Aug 24 22:04:41 2017 -0700 notmuch: add more notmuch-show bindings * p, P, C-n, C-p * initial placeholder docs for n, N commit 99a2d4e Author: William Casarin <jb55@jb55.com> Date: Wed Aug 23 18:09:12 2017 -0700 notmuch: notmuch-show message visibility bindings o: open all messages O: close all messages commit 801b6dd Author: Francesc Elies Henar <francesc.elies@gmail.com> Date: Thu Aug 24 08:01:16 2017 +0200 adds evil scroll to notmuch show mode commit ec4cd2a Author: Francesc Elies Henar <francesc.elies@gmail.com> Date: Thu Aug 24 07:59:57 2017 +0200 removes not needed functionality - functions - hook - show mail customization commit 48af3e4 Author: William Casarin <jb55@jb55.com> Date: Wed Aug 23 06:55:59 2017 -0700 notmuch: remove redundant function Replace spacemacs/notmuch-message-archive with notmuch-search-archive-thread which does the same thing. To customize tags change notmuch-archive-tags commit 3451cc9 Author: Francesc Elies Henar <francesc.elies@gmail.com> Date: Fri Aug 11 20:46:41 2017 +0200 adds notmuch layer
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes #2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
The layer has been merged in develop branch. |
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
this can be closed |
It will be closed with next release :) P. S. Missclick |
oh right |
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This patch adds a notmuch[1] layer to Spacemacs! notmuch is a mail indexing system written in C. It provides an emacs interface, and this patch adds Spacemacs support for this interface. Thanks to @FrancescElies for starting this work, and working with me to get it finished. We have been using the layer for awhile now and are happy with the initial release! Closes syl20bnr#2163 [1] https://notmuchmail.org/ Tested-by: Francesc Elies <elies@posteo.net> Tested-by: William Casarin <jb55@jb55.com> Signed-off-by: William Casarin <jb55@jb55.com>
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Please let us know if this issue is still valid! |
Can we add a new layer for notmuch ?
The text was updated successfully, but these errors were encountered: