Using a "Spacemacs/restart" function results in a wrong number of arguments error (Emacs 29.1)

[ViktorHaag]

Description

Using one of the "spacemacs/restart" calls results in a "wrong number of
arguemnts (0.0), 1" error.

Reproduction guide 🪲

• Start Emacs 29
• Use "M-m q r" to quit

Observed behaviour: 👀 💔

• Quitting using one of the "spacemacs/restart-" functions does not quit, but
  throws the wrong number of arguments error.

It appears that spacemacs is attempting to pass a "--resume-layouts" argument
down into the Emacs fundamental "restart-emacs" method, which in 29.1 seems to
be a method that does not take any parameters.

This seems like a core bug.

I have tried doing this from a fresh install of both Emacs and Spacemacs and the error occurs.

I believe that this commit here might be involved: 91f6b2d (see PR #16178).

Reverting that change seems to fix the issue.

Expected behaviour: ❤️ 😄
Emacs should restart

System Info 💻

• OS: darwin
• Emacs: 29.1
• Spacemacs: 0.999.0
• Spacemacs branch: old-local-python-mode (rev. 8d3fb17) (Personal fork)
• Graphic display: t
• Running in daemon: nil
• Distribution: spacemacs
• Editing style: emacs
• Completion: (compleseus denote-personal emacs-lisp git html ibuffer-personal javascript local-functions markdown multiple-cursors org osx python-personal restructuredtext syntax-checking tern theming treemacs yaml)
• Layers:

(compleseus denote-personal emacs-lisp git html ibuffer-personal
            (javascript :variables js-switch-indent-offset 4)
            local-functions markdown multiple-cursors
            (org :variables org-enable-github-support t org-enable-org-journal-support t)
            (osx :variables osx-command-as 'meta osx-option-as 'super osx-control-as 'control osx-function-as nil)
            python-personal restructuredtext syntax-checking tern theming
            (treemacs :variables treemacs-use-icons-dired nil)
            yaml)

• System configuration features: ACL GMP GNUTLS JSON LIBXML2 MODULES NOTIFY KQUEUE PDUMPER SQLITE3 THREADS TOOLKIT_SCROLL_BARS TREE_SITTER XWIDGETS ZLIB

Backtrace 🐾

Debugger entered--Lisp error: (wrong-number-of-arguments (0 . 0) 1)
  restart-emacs(("--resume-layouts"))
  spacemacs/restart-emacs(("--resume-layouts"))
  spacemacs/restart-emacs-resume-layouts()
  funcall-interactively(spacemacs/restart-emacs-resume-layouts)
  call-interactively(spacemacs/restart-emacs-resume-layouts nil nil)
  command-execute(spacemacs/restart-emacs-resume-layouts)

[ViktorHaag]

I notice that this open issue on restart-emacs suggests the source of the problem is a function naming collision with a core Emacs function introduced with Emacs 29.

I wonder if the suggestion in that issue of requiring files as a dependency of loading restart-emacs is expedient here? So, instead of

defun spacemacs-navigation/init-restart-emacs ()
  (use-package restart-emacs
    ;; :after files ;; this was what we had before the recent commit
    :defer (spacemacs/defer)
    :init
    (spacemacs/set-leader-keys
...

we could instead have

defun spacemacs-navigation/init-restart-emacs ()
  (use-package restart-emacs
    :require files
    ;; :defer (spacemacs/defer) ;; was switched to defer in recent commit
    :init
    (spacemacs/set-leader-keys
...

A quick test of this code-change locally seems like it would work, but I'm no expert about package loading complexities nor am I set up to do thorough testing of changes to spacemacs.

[sunlin7]

The PR #16186 should fix the issue.

[ViktorHaag]

The PR #16186 should fix the issue.

Thank you very much!

[ViktorHaag]

The PR does seem to address this issue, so I'm comfortable closing.

[sunlin7]

Thanks for your confirmation.