Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(workflow): Update github actions workflow #30

Merged
merged 1 commit into from
Mar 3, 2024
Merged

chore(workflow): Update github actions workflow #30

merged 1 commit into from
Mar 3, 2024

Conversation

proHyundo
Copy link
Contributor

@proHyundo proHyundo commented Mar 3, 2024 •
edited
Loading

Resolves #없음

Issue Define

  • Github Actions Workflow yaml 파일 수정

Summary of resolutions or improvements

  • application.yml 설정 파일을 하나의 파일로 통합함에 따라, application-test.yml 파일을 생성하지 않도록 수정했습니다.
  • 변경된 application.yml 파일을 인코딩해 Github Secrets value 에 적용했습니다.

Note

RCA Rule

r: 꼭 반영해 주세요. 적극적으로 고려해 주세요. (Request changes)
c: 웬만하면 반영해 주세요. (Comment)
a: 반영해도 좋고 넘어가도 좋습니다. 그냥 사소한 의견입니다. (Approve)

@proHyundo proHyundo added 🔗 Chore Updating grunt tasks etc(build, dependencies, config...); no production code change 💻 BackEnd Related to BackEnd labels Mar 3, 2024
@proHyundo proHyundo requested a review from yeonjookang March 3, 2024 10:49
@proHyundo proHyundo self-assigned this Mar 3, 2024
@proHyundo proHyundo marked this pull request as draft March 3, 2024 10:49
@proHyundo proHyundo changed the base branch from main to develop March 3, 2024 10:49
@proHyundo proHyundo marked this pull request as ready for review March 3, 2024 10:49
yeonjookang
yeonjookang approved these changes Mar 3, 2024
View reviewed changes
Copy link
Contributor

@yeonjookang yeonjookang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@yeonjookang yeonjookang merged commit 9580f5c into develop Mar 3, 2024
@proHyundo proHyundo deleted the github/workflow branch March 4, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yeonjookang yeonjookang yeonjookang approved these changes

Assignees

@proHyundo proHyundo

Labels
💻 BackEnd Related to BackEnd 🔗 Chore Updating grunt tasks etc(build, dependencies, config...); no production code change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@proHyundo @yeonjookang