Skip to content
This repository has been archived by the owner on Jan 10, 2025. It is now read-only.

Commit

Permalink
Drop macOS release builds
Browse files Browse the repository at this point in the history
Homebrew exists, so let's not do the same work again.

Also drop macOS from the test pipeline, to speed up the pipeline.
We don't have an macOS specific code anymore, and I don't care much
about macOS anyway.
  • Loading branch information
swsnr committed Nov 25, 2024
1 parent 7159362 commit e7456bd
Show file tree
Hide file tree
Showing 3 changed files with 14 additions and 27 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,12 +27,10 @@ jobs:
attestations: write
strategy:
matrix:
os: [ubuntu-latest, macOS-latest, windows-latest]
os: [ubuntu-latest, windows-latest]
include:
- os: ubuntu-latest
target: x86_64-unknown-linux-gnu
- os: macOS-latest
target: x86_64-apple-darwin
- os: windows-latest
target: x86_64-pc-windows-msvc
steps:
Expand Down
34 changes: 10 additions & 24 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -74,45 +74,31 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
target:
# Default linux build
- x86_64-unknown-linux-gnu
# macOS
- x86_64-apple-darwin
# Windows
- x86_64-pc-windows-msvc
include:
- target: x86_64-unknown-linux-gnu
os: ubuntu-latest
- target: x86_64-apple-darwin
os: macOS-latest
- target: x86_64-pc-windows-msvc
os: windows-latest
os: [ubuntu-latest, windows-latest]
steps:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@stable
with:
targets: ${{ matrix.target }}
components: clippy

# Since Windows builds are comparatively slow, we skip quite a few builds on Windows to speed up pipelines

# Test library with no features
- run: cargo build -p pulldown-cmark-mdcat --all-targets --locked --no-default-features
if: ${{ !contains(matrix.target, 'windows') }}
if: ${{ !contains(matrix.os, 'windows') }}
- run: cargo clippy -p pulldown-cmark-mdcat --all-targets --locked --no-default-features
if: ${{ !contains(matrix.target, 'windows') }}
if: ${{ !contains(matrix.os, 'windows') }}
- run: cargo test -p pulldown-cmark-mdcat --locked --no-default-features
if: ${{ !contains(matrix.target, 'windows') }}
if: ${{ !contains(matrix.os, 'windows') }}
- run: cargo doc -p pulldown-cmark-mdcat --locked --no-default-features
if: ${{ !contains(matrix.target, 'windows') }}
if: ${{ !contains(matrix.os, 'windows') }}

# Build and test entire workspace in default configuration
- run: cargo build --workspace --all-targets --locked --target ${{ matrix.target }}
- run: cargo clippy --workspace --all-targets --locked --target ${{ matrix.target }}
- run: cargo test --workspace --locked --target ${{ matrix.target }}
- run: cargo doc --workspace --locked --target ${{ matrix.target }}
- run: cargo build --workspace --all-targets --locked
- run: cargo clippy --workspace --all-targets --locked
- run: cargo test --workspace --locked
- run: cargo doc --workspace --locked
if: ${{ !contains(matrix.target, 'windows') }}

# Run on our complete example, just to assert that the CLI doesn't crash
- run: cargo run --target ${{ matrix.target }} -- sample/common-mark.md
- run: cargo run -- sample/common-mark.md
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ Use `cargo release` to create a new release.

## [Unreleased]

### Changed
- Drop macOS release builds. Use homebrew to obtain macOS binaries of `mdcat`.

## [2.7.0] – 2024-11-24

### Changed
Expand Down

0 comments on commit e7456bd

Please sign in to comment.