npdmtool: Correct behavior when building npdm jsons without force_debug_prod
#49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think it''s probably better to default the debug flags and only error when more than one is set as per #50 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47 introduced a breaking change to every fork of the exlaunch project.
Across GitHub, at least 40 public-facing modding projects that have been affected by the change. Some of these projects are abandoned and will not accept PRs to fix this, and currently fail to generate a complete build on the latest
switch-tools.Developers that didn't know about the 19.0.0 changes in my Discord have already updated their
switch-toolspackage and have been met with a genericFailed to parse descriptor json!error.This PR remedies the change by making
force_debug_prodoptional, supporting the older npdm jsons in exlaunch repositories.