This repository has been archived by the owner on Sep 20, 2021. It is now read-only.
fix startActivity #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| function startActivity(activityId) { | ||
| var timestamp_temp = Date.now() - timestamp; | ||
| var body = 'activityId=' + activityId + ':timestamp=' + timestamp_temp; |
There was a problem hiding this comment.
what is this timestamp calculation about?
|
thank you for your contribution! would you mind to preserve tab- and whitespace style from the original code? |
|
fixed |
swissmanu
added a commit
that referenced
this pull request
Sep 21, 2015
Improved Detection of "Activity Started"-Event This PR introduces an improved detection after starting an activity. It does not look only into the actual command reply but also at any related, published stateDigest. thx @Pmant for contribute!
|
thanks one more time @Pmant :) |
|
included in release 1.1.5 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.