[6.0] Implement count(where:) method
#72705
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
Needs to have the 6.0 PR template: https://forums.swift.org/t/swift-6-0-release-process/70220 |
stephentyrone
approved these changes
Mar 29, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cherry-pick of #70816, implementing the
Sequence.count(where:)method as proposed in SE-0220.Explanation: This changes implements the
count(where:)extension method on theSequenceprotocol.Scope: This adds one new method as a protocol extension. It does not add any new ABI, as the method is marked AEIC, which is required due to its use of typed throws. (Note that unlike with the changes to existing stdlib methods to add typed throws, there's no prior ABI for this method, so the residual hidden overload isn't necessary.)
Issue: SE-0220
Original PR: #70816
Risk: Low. When this specific API was approved and added to the stdlib in Swift 5.0 time frame, it caused type checking performance regressions due to its name collision with
Collection.count. We're confident that the type checker improvements since then will make this a non-issue.Testing: The PR includes unit testing for behavior and error handling.
Reviewer: @stephentyrone