Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build-script] Use a toolchain file and always cross compile cmark. #38124

Merged
merged 1 commit into from
Jun 29, 2021
Merged

[build-script] Use a toolchain file and always cross compile cmark. #38124

merged 1 commit into from
Jun 29, 2021

Conversation

gottesmm
Copy link
Contributor

NOTE: We still build for the host platform always, but even in that case within
cmark itself, we are cross compiling it.

@gottesmm gottesmm requested a review from drexin June 27, 2021 23:55
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

preset=buildbot_iphoneos_arm64_crosscompiler
@swift-ci Please test with preset macOS

@gottesmm
Copy link
Contributor Author

I want to prove that this still works on the bots for cross compiling cmark appropriately.

drexin
drexin approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@drexin drexin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

preset=buildbot_iphoneos_arm64_crosscompiler
@swift-ci Please test with preset macOS

@gottesmm
Copy link
Contributor Author

@swift-ci test windows platform

@gottesmm
Copy link
Contributor Author

preset=buildbot_iphoneos_arm64_crosscompiler
@swift-ci Please test with preset macOS

@gottesmm
Copy link
Contributor Author

@swift-ci test

@gottesmm
Copy link
Contributor Author

preset=buildbot_iphoneos_arm64_crosscompiler
@swift-ci Please test with preset macOS

@gottesmm
Copy link
Contributor Author

@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - a2264f1658d103c04bd1802e2b8c837dd405c3df

@gottesmm
Copy link
Contributor Author

The cross compilation for arm64 worked. There is some other bug in build-script around cross compiling but I don't believe it is caused by this PR (we are trying to build swift-test-stdlib-macosx-x86_64 which isn't generated for some reason).

@gottesmm
Copy link
Contributor Author

:doh: I forgot to make the cmark test only for macOS since I haven't fixed it yet on Linux.

@gottesmm
Copy link
Contributor Author

Once the macOS test finished, I am going to push that fix and then do a smoke test.

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - a2264f1658d103c04bd1802e2b8c837dd405c3df

@gottesmm
Copy link
Contributor Author

Timedout in LLDB

@gottesmm
[build-script] Use a toolchain file and always cross compile cmark.
d829de1 
NOTE: We still build for the host platform always, but even in that case within
cmark itself, we are cross compiling it.
@gottesmm
Copy link
Contributor Author

@swift-ci smoke test

@gottesmm
Copy link
Contributor Author

@swift-ci smoke test OS X platform

@gottesmm gottesmm merged commit f1ebf6c into swiftlang:main Jun 29, 2021
@gottesmm gottesmm deleted the pr-b1cd58be660 branch June 29, 2021 14:38
@finagolfin finagolfin mentioned this pull request Jul 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drexin drexin drexin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gottesmm @swift-ci @drexin