Add support for new Android overlay (import Android)
#7615
Conversation
|
Updated to remove the libc imports altogether from those two files where not adding the Android overlay didn't matter, and found that everything worked fine on linux x86_64 too. Let's run the CI and see if it makes a difference on any platform, as I suppose this may be handled differently on Darwin or Windows. @kateinoigakukun, would you run the CI on this now? |
|
@MaxDesiatov, need a CI run here. |
|
@swift-ci test |
|
All CI passed except for Windows, so I put back that one Windows import alone. I can restore all those libc imports, if there's concern they might be needed in other compilation scenarios. I have no idea when these libc imports are needed, so just going off compilation failures now. Another CI run and this should be ready for review. |
|
@swift-ci test |
Also, remove most libc imports for one file and one test where they weren't needed.
|
Sigh, I thought I could quickly fix some of those Another CI run and we can see if this passes now. |
|
@swift-ci test |
| import Musl | ||
| #elseif os(Windows) | ||
| import MSVCRT | ||
| import WinSDK |
There was a problem hiding this comment.
@hyp, the Windows CI passed but I notice it doesn't run the SPM tests, just builds the source? Let me know if this change is okay on Windows.
|
@xedin, maybe you can review? |
|
@bnbarham, looking for review on this tiny pull, as I currently have to manually patch the |
|
@swift-ci please test Windows platform |
import Android)
This adds the overlay to four of the six files that currently `import Glibc`, with those last two showing no difference if this _wasn't_ added, like `PackageDescription.swift`.
This adds the overlay to four of the six files that currently `import Glibc`, with those last two showing no difference if this _wasn't_ added, like `PackageDescription.swift`.
This adds the overlay to four of the six files that currently
import Glibc, with those last two showing no difference if this wasn't added, likePackageDescription.swift.