Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift Package Manager #58

Closed
wants to merge 6 commits into from
Closed

Swift Package Manager #58

wants to merge 6 commits into from

Conversation

kgn
Copy link

@kgn kgn commented Jun 9, 2017

I added support for Swift Package Manager, the changes needed to get this working were:

  • Move source files into Sources directory
  • Move test files into Tests/SwiftCSVTests
  • Change how the test csv files are loaded so they can be loaded when running tests via swift test

I also added support for running the tests on Linux to make sure the library works on that platform. There is a simple Dockerfile to run the tests by running docker build . in the root of the project.

@swiftylondon
Copy link

swiftylondon commented Jun 10, 2017

@kgn looks like Travis CI breaking again
Code 65 error appears to be a known issue:

travis-ci/travis-ci#6675

Any ideas on how to fix?

@swiftylondon
Copy link

Looks good - nice one.

@swiftylondon
Copy link

@naoty I don't seem to have permission levels to merge. Can you do it? Merge to develop and lets push this out! Nice work @kgn - thanks!

@swiftylondon
Copy link

unless @kgn can you fix the conflicts by pulling latest develop?

@kgn
Copy link
Author

kgn commented Jun 12, 2017

hmm, I'm not sure what's conflicting. I tried to rebase the changes from naoty/develop onto my branch but still saying there are conflicts

@kgn
Copy link
Author

kgn commented Jun 12, 2017

@swiftylondon all my changes were after your last commit to develop so not sure what GitHub is complaining about

@grantkemp
Copy link
Collaborator

@kgn it looks like there are some conflicts...^^ can you resolve them?

@DivineDominion
Copy link
Contributor

@kgn I'm by no means a SwiftPM expert, so could you have a look at the state of everything now that the repository is cleaned up a bit?

@DivineDominion
Copy link
Contributor

Closed via #77 as a working example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants