KafkaConsumer: store offsets when .finishing
#121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FranzBusch
approved these changes
Aug 23, 2023
FranzBusch
reviewed
Aug 23, 2023
Sources/Kafka/KafkaConsumer.swift
Outdated
| @@ -585,7 +585,9 @@ extension KafkaConsumer { | |||
| fatalError("Cannot store offset when consumption has been stopped") | |||
| case .consuming(let client, _): | |||
| return .storeOffset(client: client) | |||
| case .finishing, .finished: | |||
| case .finishing(let client): | |||
There was a problem hiding this comment.
Can we have a test for this actually
Motivation: This PR addresses issue swift-server#119. The `KafkaConsumer` should not `fatalError` when storing offsets in state `.finishing`. See swift-server#119 (comment) for more information why. Modifications: * terminate `KafkaConsumerMessages` sequences when in state `.finishing` or `.finished` instead of storing offsets
13eb697 to
604f25c
Compare
FranzBusch
approved these changes
Aug 23, 2023
|
Please merge @FranzBusch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
This PR addresses issue #119.
The
KafkaConsumershould notfatalErrorwhen storing offsets instate
.finishing.See #119 (comment) for more information why.
Modifications:
KafkaConsumerMessagessequences when in state.finishingor
.finishedinstead of storing offsets