Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt GitHub actions #780

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Adopt GitHub actions #780

merged 3 commits into from
Oct 29, 2024

Conversation

rnro
Copy link
Collaborator

@rnro rnro commented Oct 28, 2024

Migrate CI to use GitHub Actions.

Motivation:

To migrate to GitHub actions and centralised infrastructure.

Modifications:

Changes of note:

  • Adopt swift-format using rules from SwiftNIO.
  • Remove scripts and docker files which are no longer needed.
  • Disabled warnings-as-errors on Swift 6.0 CI pipelines for now.

Result:

Feature parity with old CI.

Migrate CI to use GitHub Actions.

Motivation:

To migrate to GitHub actions and centralised infrastructure.

Modifications:

Changes of note:
* Adopt swift-format using rules from SwiftNIO
* Remove scripts and docker files which are no longer needed

Result:

Feature parity with old CI.
@rnro rnro force-pushed the adopt_github_actions branch from b9abb3e to 55973f2 Compare October 28, 2024 16:35
@rnro rnro added the 🔨 semver/patch No public API change. label Oct 28, 2024
@rnro rnro force-pushed the adopt_github_actions branch 2 times, most recently from c06a962 to 5f16c7b Compare October 28, 2024 16:37
Motivation:

We currently have a range of thread-safety warnings on Swift 6.0 (which
will be errors in Swift 6 Language mode). Resolving these is out of
scope for CI work.

Modifications:

Disabled warnings-as-errors on Swift 6 CI pipelines

Result:

Resolve Swift 6 CI failures.
@rnro rnro force-pushed the adopt_github_actions branch from 5f16c7b to d3c4d56 Compare October 29, 2024 09:34
@@ -0,0 +1 @@
NOTICE.txt
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is flagged due to the master we can just switch that to a commit sha instead

@FranzBusch FranzBusch merged commit c621142 into main Oct 29, 2024
27 of 34 checks passed
@FranzBusch FranzBusch deleted the adopt_github_actions branch October 29, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 semver/patch No public API change.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants