Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read metadata db from file #7

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Read metadata db from file #7

merged 2 commits into from
Sep 12, 2024

Conversation

BobBorges
Copy link
Contributor

load_Corpus_metadata takes a long time, here we can load the medatata db from a previously saved pickle

@BobBorges BobBorges requested a review from ninpnin May 3, 2024 12:24
@ninpnin
Copy link
Contributor

ninpnin commented May 3, 2024

Do we need to pickle? CSV would be fine by me for our purposes.

@BobBorges
Copy link
Contributor Author

pickle reads in faster, and you can't accidentally change the delimiter by opening it in libre office

@ninpnin
Copy link
Contributor

ninpnin commented May 3, 2024

I have slowly become afraid of binary data types. You never know what they are hiding in them.

But if this does make your workflow faster / easier then we can do it.

@BobBorges
Copy link
Contributor Author

could always throw in a try: read_csv except: read_pickle if you want to use csv.

@ninpnin ninpnin merged commit 65f3082 into dev Sep 12, 2024
1 check passed
@BobBorges BobBorges deleted the read-metadata branch October 23, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants