Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/transforms): Pass unresolved_mark to simplifier instead of top_level_mark #9989

Merged
merged 4 commits into from
Feb 3, 2025

Conversation

CPunisher
Copy link
Member

fixes #9981

I'm not sure if this mistake is intentional.

@CPunisher CPunisher requested a review from a team as a code owner February 3, 2025 12:00
Copy link

changeset-bot bot commented Feb 3, 2025

🦋 Changeset detected

Latest commit: e3864cc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 requested a review from a team as a code owner February 3, 2025 12:03
kdy1
kdy1 previously approved these changes Feb 3, 2025
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's a mistake from old days

@kdy1 kdy1 added this to the Planned milestone Feb 3, 2025
@kdy1 kdy1 merged commit 963b088 into swc-project:main Feb 3, 2025
7 of 8 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.10.13 Feb 3, 2025
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #9989 will improve performances by 3.25%

Comparing CPunisher:02-03-fix/simplifer (7a0c5df) with main (a72c6fa)

Summary

⚡ 1 improvements
✅ 195 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
es/minifier/libs/terser 478.2 ms 463.2 ms +3.25%

@kdy1 kdy1 modified the milestones: v1.10.13, v1.10.14 Feb 8, 2025
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

optimizer.simplify: true is wrongly stripping code it shouldn't
2 participants