Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/fast-lexer): Use lookup table for lexing operators #10154

Closed
wants to merge 2 commits into from
Closed

perf(es/fast-lexer): Use lookup table for lexing operators #10154

wants to merge 2 commits into from

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Mar 6, 2025 •
edited
Loading

Description:

Related issue:

@kdy1 kdy1 self-assigned this Mar 6, 2025
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 6, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: 52869ce

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 force-pushed the kdy1/even-fast-lexer branch from a420fcf to 6a1d5d1 Compare March 6, 2025 18:08
@kdy1 kdy1 force-pushed the kdy1/even-fast-lexer branch from 6a1d5d1 to 656502b Compare March 6, 2025 18:10
@kdy1 kdy1 changed the title perf(es/fast-lexer): Use lookup table and SIMD in more places perf(es/fast-lexer): Use lookup table for lexing operators Mar 6, 2025
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Mar 6, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10154 will not alter performance

Comparing kdy1/even-fast-lexer (52869ce) with main (fb610b0)

Summary

✅ 152 untouched benchmarks

@kdy1 kdy1 added this to the Planned milestone Mar 6, 2025
@kdy1 kdy1 marked this pull request as ready for review March 6, 2025 20:00
@kdy1 kdy1 requested a review from a team as a code owner March 6, 2025 20:00
@kdy1 kdy1 marked this pull request as draft March 6, 2025 20:00
@kdy1
Copy link
Member Author

kdy1 commented Mar 6, 2025

Closing as there's no perf diff

@kdy1 kdy1 closed this Mar 6, 2025
@kdy1 kdy1 deleted the kdy1/even-fast-lexer branch March 6, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
Planned
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1