Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v1.5.20 exploded. Please fix version to 1.5.7 for now #8988

Closed
mateussaggin opened this issue May 28, 2024 · 17 comments
Closed

v1.5.20 exploded. Please fix version to 1.5.7 for now #8988

mateussaggin opened this issue May 28, 2024 · 17 comments
Assignees
@kdy1
Milestone
v1.5.22

Comments

@mateussaggin
Copy link

swc/packages/core/package.json

Line 94 in b4799f7

"@swc/types": "workspace:^"

@kdy1
Copy link
Member

kdy1 commented May 28, 2024

76b4de1 would fix it, but I'll close this issue after verifying that it works.

@kdy1 kdy1 modified the milestones: Planned, v1.5.12 May 28, 2024
@cope
Copy link

cope commented May 28, 2024 •
edited
Loading

I'm guessing that is the cause for pnpm/pnpm#6603 (comment) ?

ERR_PNPM_WORKSPACE_PKG_NOT_FOUND  In : "@swc/types@workspace:^" is in the dependencies but no package named "@swc/types" is present in the workspace

@cope cope mentioned this issue May 28, 2024
Open
@hakimassouane2
Copy link

I'm guessing that is the cause for pnpm/pnpm#6603 (comment) ?

ERR_PNPM_WORKSPACE_PKG_NOT_FOUND  In : "@swc/types@workspace:^" is in the dependencies but no package named "@swc/types" is present in the workspace

Most likely, I'm having the same issue

@lifeiscontent
Copy link

looks like the way publishing worked in swc changed maybe some hooks are no longer running as expected? v1.5.11...main

lourot added a commit to Frameright/react-image-display-control that referenced this issue May 28, 2024
@lourot
qual: work around broken @swc/core 1.5.11
36fd2c3 
See swc-project/swc#8988
@Aarebecca
Copy link

Ran into the same problem, did you use npm directly when publishing

@kdy1
Copy link
Member

kdy1 commented May 28, 2024

@Aarebecca Yeap, exactly. I changed it to use yarn npm publish and triggered a new release

@lifeiscontent
Copy link

@kdy1 any thoughts on using pnpm I've found using it for monorepo management to be a lot easier especially around publishing

@leezCtt
Copy link

leezCtt commented May 28, 2024

screenshot-20240528-155901

@maoxiaoke
Copy link

maoxiaoke commented May 28, 2024 •
edited
Loading

Same here

image

@cckn
Copy link

cckn commented May 28, 2024 •
edited
Loading

To resolve this, fix the version of "@swc/core": "1.5.7". No caret(^)

"dependencies": {
  "@swc/core": "1.5.7"
}

If @swc/core is not installed, install version 1.5.7:

npm install @swc/core@1.5.7
# or
yarn add @swc/core@1.5.7
# or 
pnpm install @swc/core@1.5.7

@kdy1 kdy1 changed the title Uhh something explode v1.5.11 exploded May 28, 2024
@kdy1 kdy1 pinned this issue May 28, 2024
@kdy1 kdy1 changed the title v1.5.11 exploded v1.5.11 exploded. Fix version to 1.5.7 for now May 28, 2024
@kdy1 kdy1 changed the title v1.5.11 exploded. Fix version to 1.5.7 for now v1.5.11 exploded. Please fix version to 1.5.7 for now May 28, 2024
@maziar-dandc maziar-dandc mentioned this issue May 28, 2024
Closed
@vagusX vagusX mentioned this issue May 28, 2024
Closed
RomainLanz added a commit to adonisjs/web-starter-kit that referenced this issue May 28, 2024
@RomainLanz
fix: force @swc/core version
fcf9333 
An error has been pushed in their latest release, making it impossible to install.
See: swc-project/swc#8988
RomainLanz added a commit to adonisjs/inertia-starter-kit that referenced this issue May 28, 2024
@RomainLanz
fix: force @swc/core version
f69dc43 
An error has been pushed in their latest release, making it impossible to install.
See: swc-project/swc#8988
@xqin
Copy link

xqin commented May 28, 2024

PLEASE UNPUBLISH @swc/core@1.5.11 FIRST!!!

@ArnaudBarre ArnaudBarre mentioned this issue May 28, 2024
Closed
7 tasks
@cckn cckn mentioned this issue May 28, 2024
Closed
3 tasks
RomainLanz added a commit to adonisjs/api-starter-kit that referenced this issue May 28, 2024
@RomainLanz
fix: force @swc/core version
ae82aa9 
An error has been pushed in their latest release, making it impossible to install.
See: swc-project/swc#8988
@cckn cckn mentioned this issue May 28, 2024
Closed
RomainLanz added a commit to adonisjs/slim-starter-kit that referenced this issue May 28, 2024
@RomainLanz
fix: force @swc/core version
af4997a 
An error has been pushed in their latest release, making it impossible to install.
See: swc-project/swc#8988
@hirotomoyamada hirotomoyamada mentioned this issue May 28, 2024
Closed
3 tasks
@awanlin awanlin mentioned this issue May 28, 2024
Closed
2 tasks
@vscaiceanu-1a vscaiceanu-1a mentioned this issue May 28, 2024
Merged
@Tobbe Tobbe mentioned this issue May 28, 2024
Merged
vscaiceanu-1a added a commit to AmadeusITGroup/otter that referenced this issue May 28, 2024
@vscaiceanu-1a
fix: freeze @swc/core to 1.5.7 (#1828)
ccb1507 
## Proposed change

Freezing `@swc/core` while waiting for
swc-project/swc#8988
@mischnic mischnic mentioned this issue May 28, 2024
Closed
@FrozenPandaz FrozenPandaz mentioned this issue May 28, 2024
Merged
FrozenPandaz added a commit to nrwl/nx that referenced this issue May 28, 2024
@FrozenPandaz
chore(repo): disable failing swc e2e test (#26166)
7088b09 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
swc-project/swc#8988 is causing e2e tests to
fail.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The failing e2e tests are disabled while the issue is resolved.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #
FrozenPandaz added a commit to nrwl/nx that referenced this issue May 28, 2024
@FrozenPandaz
chore(repo): disable failing swc e2e test (#26166)
4947155 
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

## Current Behavior
<!-- This is the behavior we have today -->
swc-project/swc#8988 is causing e2e tests to
fail.

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

The failing e2e tests are disabled while the issue is resolved.

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 7088b09)
@heozeop
Copy link

heozeop commented May 29, 2024 •
edited
Loading

Will this issue be resolved soon ? Or I'll just do update using "resolutions": {"@swc/core":"1.5.7"}

@kdy1
Copy link
Member

kdy1 commented May 29, 2024

image

I'm trying my best. And normally, you don't need overriding because the latest tag of npm is 1.5.7

@valentinpalkovic
Copy link

valentinpalkovic commented May 29, 2024 •
edited
Loading

@kdy1 Overriding is still necessary if @swc/core's version is defined as a version range (e.g. ^1.5.7). Then, it doesn't matter which version is tagged with latest. The package manager yarn (v4) will install the latest available stable version that is published (as of now 1.5.20 - which is borked as well). This is an issue at Storybook because @swc/core is a transitive dependency, and we have to publish new versions of our packages so that our users will not run into issues.

// from the `yarn.lock`
"@swc/core@npm:^1.5.7":
  version: 1.5.20
  resolution: "@swc/core@npm:1.5.20"
  ...

@kdy1 kdy1 changed the title v1.5.11 exploded. Please fix version to 1.5.7 for now v1.5.11/v1.5.20 exploded. Please fix version to 1.5.7 for now May 29, 2024
@kdy1 kdy1 changed the title v1.5.11/v1.5.20 exploded. Please fix version to 1.5.7 for now v1.5.20 exploded. Please fix version to 1.5.7 for now May 29, 2024
@benjdlambert benjdlambert mentioned this issue May 29, 2024
Merged
shilman added a commit to storybookjs/addon-webpack5-compiler-swc that referenced this issue May 29, 2024
@shilman
Pin @swc/core to v1.5.7
09800a3 
See swc-project/swc#8988
@shilman shilman mentioned this issue May 29, 2024
Merged
shilman added a commit to storybookjs/test-runner that referenced this issue May 29, 2024
@shilman
Pin @swc/core to 1.5.7
9bf1a01 
swc-project/swc#8988
@shilman shilman mentioned this issue May 29, 2024
Merged
@kdy1 kdy1 self-assigned this May 30, 2024
@kdy1 kdy1 modified the milestones: v1.5.12, Planned May 30, 2024
@kdy1
Copy link
Member

kdy1 commented May 30, 2024

Finally it's fixed.

@kdy1 kdy1 closed this as completed May 30, 2024
@kdy1 kdy1 unpinned this issue May 30, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.5.22 May 30, 2024
@Tobbe Tobbe mentioned this issue Jun 3, 2024
Merged
@ysgk ysgk mentioned this issue Jun 10, 2024
Merged
3 tasks
@swc-bot
Copy link
Collaborator

swc-bot commented Jun 29, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.22
Development

No branches or pull requests