swc-cli: -C "exclude=.*\.spec\.ts" doesn't work from the cli, while it works ok from .swcrc file

[MohamedLamineAllal]

Describe the bug

npx swc src --out-dir "some dist" -C "exclude=.*.spec.ts$"

Doesn't work.

While exclude: [".*.spec.ts$"] works if used in .swcrc.

Expected behavior

Should work just like it does with .swcrc

Version

@swc/cli: 0.1.57, @swc/core: 1.3.1

[MohamedLamineAllal]

I analyzed the code a bit. To get a better understanding.

And basically, it seems the only place where the exclude matching happens is through the RC.into_config() method. And in Compiler.read_config() method. The excluded value from opts is not used. And only the one read from files.

And i guess adding the bellow in Compiler.parse_js_as_input():

   // adding
   if let FileName::Real(ref path) = name {
       if !opts.config.matches(path)? {
           return Ok(None);
       }
   }
   // before read_config
   let config = self.read_config(opts, name)?;
   // .....

Should fix that. Before read_config, to avoid reading the configurations. If the file is to be excluded.

[MohamedLamineAllal]

Another question,

Why the src files are read before exclusion and matching?

bindings/binding_core_node/src/transform.rs#L67

      Input::File(ref path) => {
          let fm = self.c.cm.load_file(path).context("failed to load file")?;
          self.c.process_js_file(fm, handler, &options)
      }

[MohamedLamineAllal]

Here a draft PR #6054

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.