Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Upgrade chokidar to v4 #76

Merged
merged 4 commits into from
Jan 7, 2025
Merged

chore: Upgrade chokidar to v4 #76

merged 4 commits into from
Jan 7, 2025

Conversation

danPwiz
Copy link
Contributor

@danPwiz danPwiz commented Dec 16, 2024

All cli test pass.
Screenshot 2024-12-16 at 21 10 01

Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: 947b89e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@swc/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2024

CLA assistant check
All committers have signed the CLA.

Copy link

socket-security bot commented Dec 16, 2024

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@swc/cli@0.5.2 environment, filesystem +1 182 kB kdy1
npm/chokidar@4.0.1 environment, filesystem 0 257 kB paulmillr
npm/minimatch@9.0.3 environment +2 452 kB isaacs

🚮 Removed packages: npm/chokidar@3.5.1, npm/slash@3.0.0

View full report↗︎

@danPwiz
Copy link
Contributor Author

danPwiz commented Dec 16, 2024

@kdy1

Can you please take a look. I see that the checks fail on other PRs as well so I guess it's unrelated to my changes.
I have ran a test that uses watch: true and it works. Should I commit the test as well?
Is there another way to validate that the new package works?

@kdy1
Copy link
Member

kdy1 commented Jan 7, 2025

Sorry for the delay

@kdy1 kdy1 changed the title trivial: upgraded chokidar package to v4 chore: Upgrade chokidar to v4 Jan 7, 2025
@kdy1 kdy1 merged commit a031d35 into swc-project:main Jan 7, 2025
3 of 11 checks passed
@vscaiceanu-1a
Copy link

Hello @kdy1,
Any idea when @swc/cli 0.6.0 will be out?

@danPwiz
Copy link
Contributor Author

danPwiz commented Jan 8, 2025

@kdy1 Thank you for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants