This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
xdg-decoration: refactor configure/state flow #3228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14cbf8f to
47c7a91
Compare
The same logic/motivation as xdg-toplevel.
47c7a91 to
f465284
Compare
bl4ckb0ne
reviewed
Oct 7, 2021
bl4ckb0ne
approved these changes
Oct 7, 2021
|
LGTM, thanks! |
|
Thanks for reviewing! |
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preliminary work for #3151.
This is a breaking change:
wlr_xdg_toplevel_decoration_v1.client_pending_modehas been renamed towlr_xdg_toplevel_decoration_v1.requested_mode.wlr_xdg_toplevel_decoration_v1.server_pending_modehas been renamed towlr_xdg_toplevel_decoration_v1.scheduled_mode.wlr_xdg_toplevel_decoration_v1.current_modehas been moved towlr_xdg_toplevel_decoration_v1_stateand is double-buffered.For reviewers:
toplevel_decoration_handle_surface_commitis now called on every commit. The logic should be correct, but I haven't tested all possible cases.