This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
render/allocator: re-open GBM FD #3153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the same DRM file description for the DRM backend and for the GBM allocator will result in GEM handle ref'counting issues [1]. Re-open the DRM FD to fix these issues. [1]: https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/110
This was referenced Sep 1, 2021
subdiff
approved these changes
Sep 1, 2021
bl4ckb0ne
approved these changes
Sep 1, 2021
|
LGTM |
quantum5
reviewed
Sep 1, 2021
| /* Re-open the DRM node to avoid GEM handle ref'counting issues. See: | ||
| * https://gitlab.freedesktop.org/mesa/drm/-/merge_requests/110 | ||
| * TODO: don't assume we have the permission to just open the DRM node, | ||
| * find another way to re-open it. |
There was a problem hiding this comment.
Does dup(2) work or do we have to reopen by name?
There was a problem hiding this comment.
Unfortunately dup(2) doesn't work here, because the GEM handlers are per file description. dup(2) only gives a new file descriptor, but shares the same file description on the kernel side. See the linked libdrm discussion above.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the same DRM file description for the DRM backend and for the
GBM allocator will result in GEM handle ref'counting issues 1.
Re-open the DRM FD to fix these issues.