Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

buffer: drop wlr_client_buffer.resource #3039

Merged
merged 5 commits into from
Jul 9, 2021

Conversation

emersion
Copy link
Member

@emersion emersion commented Jul 9, 2021

See individual commits.

@emersion emersion added the breaking Breaking change in public API label Jul 9, 2021
@bl4ckb0ne
Copy link
Contributor

LGTM, do you want it merged before or after #3023 ?

@emersion
Copy link
Member Author

emersion commented Jul 9, 2021

Let's wait for #3023, should be ready soon!

We often juggle between wlr_buffer and wlr_client_buffer variables.
Use a consistent naming: "buffer" for wlr_buffer and "client_buffer"
for wlr_client_buffer.
@emersion emersion force-pushed the drop-client-buffer-resource branch from 932f500 to 2830fc2 Compare July 9, 2021 21:20
emersion added 4 commits July 9, 2021 23:22
This is the first step towards dropping wlr_client_buffer.resource.
This stores a weak reference to the source buffer.
Instead, delegate to the source wlr_buffer.
@emersion emersion force-pushed the drop-client-buffer-resource branch from 2830fc2 to f5d2b33 Compare July 9, 2021 21:22
@bl4ckb0ne bl4ckb0ne merged commit 4554f17 into swaywm:master Jul 9, 2021
@emersion emersion mentioned this pull request Jul 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
breaking Breaking change in public API
Development

Successfully merging this pull request may close these issues.

2 participants