layer-shell: ignore all requests if surface is closed

The protocol specifies that all requests (aside from destroy) are
ignored after the compositor sends the closed event. This change
simplifies proper layer shell implementation for compositors by moving
this logic inside wlroots.

types/wlr_layer_shell_v1.c

@@ -99,7 +99,7 @@ static void layer_surface_handle_set_size(struct wl_client *client,
 		struct wl_resource *resource, uint32_t width, uint32_t height) {
 	struct wlr_layer_surface_v1 *surface = layer_surface_from_resource(resource);
 
-	if (!surface) {
+	if (!surface || surface->closed) {
 		return;
 	}
 	surface->client_pending.desired_width = width;
@@ -120,7 +120,7 @@ static void layer_surface_handle_set_anchor(struct wl_client *client,
 	}
 	struct wlr_layer_surface_v1 *surface = layer_surface_from_resource(resource);
 
-	if (!surface) {
+	if (!surface || surface->closed) {
 		return;
 	}
 	surface->client_pending.anchor = anchor;
@@ -130,7 +130,7 @@ static void layer_surface_handle_set_exclusive_zone(struct wl_client *client,
 		struct wl_resource *resource, int32_t zone) {
 	struct wlr_layer_surface_v1 *surface = layer_surface_from_resource(resource);
 
-	if (!surface) {
+	if (!surface || surface->closed) {
 		return;
 	}
 	surface->client_pending.exclusive_zone = zone;
@@ -141,7 +141,7 @@ static void layer_surface_handle_set_margin(
 		int32_t top, int32_t right, int32_t bottom, int32_t left) {
 	struct wlr_layer_surface_v1 *surface = layer_surface_from_resource(resource);
 
-	if (!surface) {
+	if (!surface || surface->closed) {
 		return;
 	}
 	surface->client_pending.margin.top = top;
@@ -155,7 +155,7 @@ static void layer_surface_handle_set_keyboard_interactivity(
 		uint32_t interactive) {
 	struct wlr_layer_surface_v1 *surface = layer_surface_from_resource(resource);
 
-	if (!surface) {
+	if (!surface || surface->closed) {
 		return;
 	}
 
@@ -180,7 +180,7 @@ static void layer_surface_handle_get_popup(struct wl_client *client,
 	struct wlr_xdg_surface *popup_surface =
 		wlr_xdg_surface_from_popup_resource(popup_resource);
 
-	if (!parent) {
+	if (!parent || parent->closed) {
 		return;
 	}
 	assert(popup_surface->role == WLR_XDG_SURFACE_ROLE_POPUP);
@@ -194,7 +194,7 @@ static void layer_surface_set_layer(struct wl_client *client,
 		struct wl_resource *surface_resource, uint32_t layer) {
 	struct wlr_layer_surface_v1 *surface =
 			layer_surface_from_resource(surface_resource);
-	if (!surface) {
+	if (!surface || surface->closed) {
 		return;
 	}
 	if (layer > ZWLR_LAYER_SHELL_V1_LAYER_OVERLAY) {