Bug fix to support multiple temporary directories #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…porary_directory are set. Fixed by dealing temporary_directory with the same method with temporary2_directory
|
You forgot to include a change required in processes.py. But looks like #153 should take care of that. |
|
Thanks for pointing that out! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug:
When set temporary_directory as a list like this:
temporary_directory:
- /media/temp0/Plots
- /media/temp1/Plots
The chia command will include -t ['/media/temp0/Plots' '/media/temp1/Plots'], which is an invalid input for chia.
This commit fixes such bug to support multiple temporary directories.
It just copies the mechanisms for destination_directory and temporary2_directory.
Thus, tasks could utilize input temporary directories one after one.
Tested on Ubuntu 20.04, python 3.8