-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix calls to lenstronomy for new version #54
fix calls to lenstronomy for new version #54
Conversation
smericks
commented
Dec 8, 2023
- PointSource() now takes in 'lens_model' instead of 'lensModel' as a kwarg (change to config_handler.py)
- remove use of a private function in MainDeflector.simple_deflectors.py
…sion of lenstronomy
@swagnercarena this PR should be merged ASAP to guarantee consistency with lenstronomy. I think the issue with the test failing is that paltas required an older version of lenstronomy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes look correct, but it seems like the pip version of lenstronomy did not include this new feature when the tests were run. Let's try to get the tests to run again to make sure everything is in order now.
@smericks, can you modify the lenstronomy requirements to the new pip version with this change? That should also trigger the tests to run again. |
Updated lenstronomy version
@swagnercarena @sibirrer So the switch from_import_class() to lens_class() happened Oct 27th (lenstronomy/lenstronomy@f815d06) But the latest pip version of lenstronomy is from Sep 28th (https://github.com/lenstronomy/lenstronomy/releases/tag/v1.11.5) So I don't think this change is compatible with a pip release of lenstronomy yet. Since I'm working with more up to date lenstronomy than the pip release, I tried to jump the gun on changing this. |
Okay, let's circle back to this pull request once the newest pip version of lenstronomy is compatible with the change. Thanks @smericks! |
ah, I see. On my way for a new lenstronomy release and then ping here. Thank you! |
@smericks @swagnercarena lenstronomy version 1.11.6 is available on pip |
now requires lenstronomy >= 1.11.6