Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove download button when content is empty #8579

Merged
merged 7 commits into from
Apr 26, 2023
Merged

fix: remove download button when content is empty #8579

merged 7 commits into from
Apr 26, 2023

Conversation

kowalczyk-krzysztof
Copy link
Contributor

This PR fixes an edge case where if user specifies content-type as application/octet-stream and content-length as 0 the Download file button appears even though there is nothing to download.

@tekyu tekyu self-requested a review April 21, 2023 08:08
char0n
char0n requested changes Apr 26, 2023
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @kowalczyk-krzysztof,

Thanks for the PR and bringing up this issue! Please look at the code review suggestions and comments which we need to address before this change gets merged.

src/core/components/response-body.jsx Outdated Show resolved Hide resolved
char0n
char0n reviewed Apr 26, 2023
View reviewed changes
test/unit/setup.js Outdated Show resolved Hide resolved
char0n
char0n approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@char0n char0n merged commit cdfc4de into master Apr 26, 2023
@kowalczyk-krzysztof kowalczyk-krzysztof deleted the bug/remove-download-button-when-content-length-is-zero branch April 26, 2023 12:06
ksibisamir added a commit to SaTT-Wallet/Backend that referenced this pull request May 31, 2023
@ksibisamir
[Snyk] Upgrade swagger-ui-dist from 4.14.3 to 4.18.3 (#186)
0f597a9 
<h3>Snyk has created this PR to upgrade swagger-ui-dist from 4.14.3 to
4.18.3.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **13 versions** ahead of your current
version.
- The recommended version was released **24 days ago**, on 2023-04-26.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>swagger-ui-dist</b></summary>
    <ul>
      <li>
<b>4.18.3</b> - <a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/releases/tag/v4.18.3">2023-04-26</a></br><h2><a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/compare/v4.18.2...v4.18.3">4.18.3</a>
(2023-04-26)</h2>
<h3>Bug Fixes</h3>
<ul>
<li><strong>response-body:</strong> remove download button when content
is empty (<a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/issues/8579"
data-hovercard-type="pull_request"
data-hovercard-url="/swagger-api/swagger-ui/pull/8579/hovercard">#8579</a>)
(<a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/commit/cdfc4de43e486f592b9e471968c7a172d8d8072c">cdfc4de</a>)</li>
</ul>
      </li>
      <li>
<b>4.18.2</b> - <a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/releases/tag/v4.18.2">2023-03-30</a></br><h2><a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/compare/v4.18.1...v4.18.2">4.18.2</a>
(2023-03-30)</h2>
<h3>Bug Fixes</h3>
<ul>
<li>decode model schema name on model component (<a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/issues/8400"
data-hovercard-type="pull_request"
data-hovercard-url="/swagger-api/swagger-ui/pull/8400/hovercard">#8400</a>)
(<a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/commit/44e2700c7400f872fd6b0b78d8aa2a0f73fb2807">44e2700</a>),
closes <a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/issues/5626"
data-hovercard-type="issue"
data-hovercard-url="/swagger-api/swagger-ui/issues/5626/hovercard">#5626</a></li>
<li><strong>oas3:</strong> expand Callback operation without browser
error (<a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/issues/8510"
data-hovercard-type="pull_request"
data-hovercard-url="/swagger-api/swagger-ui/pull/8510/hovercard">#8510</a>)
(<a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/commit/cb15dbb6e5544aa69a5ab04358f5fed46e253183">cb15dbb</a>),
closes <a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/issues/7465"
data-hovercard-type="issue"
data-hovercard-url="/swagger-api/swagger-ui/issues/7465/hovercard">#7465</a></li>
</ul>
      </li>
      <li>
        <b>4.18.1</b> - 2023-03-10
      </li>
      <li>
        <b>4.18.0</b> - 2023-03-08
      </li>
      <li>
        <b>4.17.1</b> - 2023-03-06
      </li>
      <li>
        <b>4.17.0</b> - 2023-03-01
      </li>
      <li>
        <b>4.16.1</b> - 2023-02-25
      </li>
      <li>
        <b>4.16.0</b> - 2023-02-24
      </li>
      <li>
        <b>4.15.5</b> - 2022-11-09
      </li>
      <li>
        <b>4.15.3</b> - 2022-11-08
      </li>
      <li>
        <b>4.15.2</b> - 2022-10-26
      </li>
      <li>
        <b>4.15.1</b> - 2022-10-25
      </li>
      <li>
        <b>4.15.0</b> - 2022-10-20
      </li>
      <li>
        <b>4.14.3</b> - 2022-10-11
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/swagger-api/swagger-ui/releases">swagger-ui-dist
GitHub release notes</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiI4MTkwMDhiMS0xNjhkLTQzZDItOGIxYS0zNzk0ODBlOTg0ODYiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjgxOTAwOGIxLTE2OGQtNDNkMi04YjFhLTM3OTQ4MGU5ODQ4NiJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00/settings/integration?pkg&#x3D;swagger-ui-dist&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"819008b1-168d-43d2-8b1a-379480e98486","prPublicId":"819008b1-168d-43d2-8b1a-379480e98486","dependencies":[{"name":"swagger-ui-dist","from":"4.14.3","to":"4.18.3"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/satt/project/b89486be-ad07-4d6c-a51a-2fa8a25baa00?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"b89486be-ad07-4d6c-a51a-2fa8a25baa00","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":13,"publishedDate":"2023-04-26T13:12:06.316Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->
@nick-coremont
Copy link

@kowalczyk-krzysztof @char0n @tekyu I believe this PR caused a regression: #9298

@char0n
Copy link
Member

char0n commented Oct 12, 2023

@nick-coremont can you corroborate please?

@nick-coremont
Copy link

@char0n What do you mean please? I believe the issue I referenced includes the required evidence.

@char0n
Copy link
Member

char0n commented Nov 9, 2023

@nick-coremont sorry, I've overlooked the link to #9298. Handling it now. Thanks!

@char0n char0n mentioned this pull request Nov 9, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@char0n char0n char0n approved these changes

@tekyu tekyu tekyu approved these changes

@frantuma frantuma Awaiting requested review from frantuma

Assignees
No one assigned
Labels
type: bug version: 4.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kowalczyk-krzysztof @nick-coremont @char0n @tekyu