Adding ScrollTo support for Models #5237
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added onLoad functions and tweaked an onToggle function in the following files:
src/core/components/models.jsx
src/core/components/model-collapse.jsx
src/core/components/model-wrapper.jsx
Motivation and Context
We would like ScrollTo to work for Models for when the SpecPath is in the URL Fragment (hash)
How Has This Been Tested?
This has been tested by overriding the component using the plugin architecture in our system.
Manual tests by our QA team
Screenshots (if appropriate):
Checklist
My PR contains...
src/
is unmodified: changes to documentation, CI, metadata, etc.)package.json
)My changes...
Documentation
Automated tests
^ I'm not 100% sure about Documentation & Tests, please let me know otherwise