Fixed OAuth2 Password flow to match the RFC requirements #3226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RFC 6749 says that the `scope` parameter should be named as `scope` (rather than `scopes`) and there is no need to encode the string as it is passed via form parameters, which are encoded automatically.
|
While this PR is valid, I discovered another inconsistency with RFC, so I will report the issue shortly and then update the PR to fix it. |
|
Well, I think this PR can be merged as is because it can be considered as a typo (other OAuth2 Flows use Here is my thorough summary of the state of OAuth2 Password Flow implementation in Swagger-UI: #3227. |
|
please merge. hit this just now. issue confirmed - parameter needs to be named |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC 6749 says that the
scopeparameter should be named asscope(rather thanscopes) and there is no need to encode the string as it is passed via form parameters, which are encoded automatically.