Basic Auth - OAuth Password Flow #3174
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove check on password type basic for client_id and client_secret visibility
Put client_id and secret in form data when using basic auth
Update password flow for basic auth. Set user/password in body and set basic auth to use clientdi/secret
|
@bodnia can you please review this PR? |
|
@benoj can you please add one more point to drop-down to cover this case? |
|
@benoj You didn't need to do this! The thing you were looking for was just named incorrectly as "Request body" type. Read more in #3227. Please, do not merge this in until read #3227! I think this PR should be closed as the implemented functionality duplicates the existing (incorrectly named) "Request body" type. |
|
@bodnia which case am i covering? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides ClientId/Secret in BASIC auth header and always provides user/pass in request body see #3173