Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for binary downloads, inline image rendering #2404

Merged
merged 5 commits into from
Sep 16, 2016
Merged

Conversation

fehguy
Copy link
Contributor

@fehguy fehguy commented Sep 15, 2016

Adds support for downloading binary files when the Content-Disposition and attachment headers are returned from the client. Only supports SuperAgent and not JQuery.

Additionally renders images inline using data attributes to avoid extra calls, which allows operations POST to return images and render correctly. Previously rendering was handled in GET calls only.

Fixes #2132, #2371, #2226, #1848, #1605

@fehguy
Copy link
Contributor Author

fehguy commented Sep 15, 2016

Note, this is using a pending PR of swagger-js. To rebuild, you'll have to do the npm link dance. Or just use the pre-built dist folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant