Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can no longer upload file using multipart file upload #5997

Closed
travishaagen opened this issue May 11, 2020 · 2 comments · Fixed by #6000
Closed

Can no longer upload file using multipart file upload #5997

travishaagen opened this issue May 11, 2020 · 2 comments · Fixed by #6000

Comments

@travishaagen
Copy link

travishaagen commented May 11, 2020

Q&A

  • OS: macOS
  • Browser: chrome
  • Version: 81.0.4044.129
  • Method of installation: dist assets
  • Swagger-UI version: 3.25.2
  • Swagger/OpenAPI version: Swagger 2.0

Content & configuration

Example Swagger/OpenAPI definition:

      "parameters": [
        {
          "name": "multipart-form",
          "in": "formData",
          "description": "One or more CSV files to upload.",
          "required": true,
          "type": "file"
        }
      ]
    }

Describe the bug you're encountering

When you choose a file to upload, the UI mistakenly thinks that there is a validation error and will prevent execution of the request.

To reproduce...

Configure an operation parameter as shown in the JSON above.

Expected behavior

Choosing a file should allow the request to be executed. This problem is not present in Swagger UI version 3.24.3.

Screenshots

upload

@tim-lai
Copy link
Contributor

tim-lai commented May 11, 2020

@travishaagen Hi Travis, thanks for reporting this issue! This is indeed a regression in the most recent release, and will be fixed in the next release.

@almostjulian
Copy link

What's the timeline for release?

tim-lai added a commit to tim-lai/swagger-ui that referenced this issue May 14, 2020
tim-lai added a commit that referenced this issue May 14, 2020
Pentusha added a commit to Pentusha/swagger-ui that referenced this issue May 27, 2020
* 'master' of github.com:swagger-api/swagger-ui: (37 commits)
  release: v3.25.4
  chore(package): bump swagger-client to 3.10.4 version
  fix: entries as property name (swagger-api#6025)
  release: v3.25.3
  housekeeping: update release-it config (swagger-api#6009)
  housekeeping: bump swagger-client version with package-lock (swagger-api#6008)
  housekeeping: update dev-e2e-cypress-open script name (swagger-api#6005)
  fix: jsonSchemaComponent file/files (swagger-api#5997) (swagger-api#6000)
  fix: curl array support within multipart/form-data (swagger-api#3838) (swagger-api#5999)
  release: v3.25.2
  bug: remove clearValidation from onTryoutClick (swagger-api#5955)
  ft: JsonSchema components are now ImmutableJS compliant (swagger-api#5952)
  release: v3.25.1
  housekeeping: revert @release-it/conventional-changelog version (swagger-api#5976)
  housekeeping: add missing conventional-changelog devDeps (swagger-api#5975)
  docs: update plugin api component for failSilently (swagger-api#5953)
  housekeeping: `npm audit fix` (swagger-api#5948)
  housekeeping: prevent log warning for missing getComponent in production
  fix(docker-image): send relative HTTP 301s from within container (swagger-api#5409)
  support for supportedSubmitMethods property in react component (swagger-api#5376)
  ...
mattyb678 pushed a commit to mattyb678/swagger-ui that referenced this issue Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants