Add validation for oauth password flow

swagger-api · Nov 12, 2016 · ddcb4b9 · ddcb4b9
1 parent 561eb3c
commit ddcb4b9
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 1 deletion.
diff --git a/src/main/javascript/view/Oauth2Model.js b/src/main/javascript/view/Oauth2Model.js
@@ -24,6 +24,11 @@ SwaggerUi.Models.Oauth2Model = Backbone.Model.extend({
 
     validate: function () {
       var valid = false;
+      if (this.get('isPasswordFlow') &&
+          (!this.get('username'))) {
+          return false;
+      }
+
       var scp = this.get('scopes');
       var idx =  _.findIndex(scp, function (o) {
          return o.checked === true;

diff --git a/src/main/javascript/view/Oauth2View.js b/src/main/javascript/view/Oauth2View.js
@@ -9,6 +9,10 @@ SwaggerUi.Views.Oauth2View = Backbone.View.extend({
 
     template: Handlebars.templates.oauth2,
 
+    cls: {
+        error: 'error'
+    },
+
     render: function () {
         this.$el.html(this.template(this.model.toJSON()));
 
@@ -23,10 +27,20 @@ SwaggerUi.Views.Oauth2View = Backbone.View.extend({
     },
 
     setUsername: function (e) {
-        this.model.set('username', $(e.target).val());
+        var val= $(e.target).val();
+        this.model.set('username', val);
+        if (val) {
+            $(e.target).removeClass(this.cls.error);
+        }
     },
 
     setPassword: function (e) {
         this.model.set('password', $(e.target).val());
+    },
+
+    highlightInvalid: function () {
+        if (!this.model.get('username')) {
+            this.$el.find('.oauth-username').addClass(this.cls.error);
+        }
     }
 });